Ada-Developers-Academy / classroom-app

Application for tracking and providing feedback on Ada student PRs
http://classroom.adadevelopersacademy.org/
2 stars 5 forks source link

Minor bug fixes uncovered during deployment #48

Closed Hamled closed 7 years ago

Hamled commented 7 years ago

The first is some kind of issue that Heroku's systems have with installing the rdoc gem version 4.2.0. One fix that seems to work is forcing the version of rdoc to 4.3.

The second issue I noticed when testing the new invite system with a test account that I set up on GitHub. I didn't give it a name at first and was unable to log in as a result.

Now if someone logs in and has no name set on GitHub we default to using their login name. In the future we should do one or both of the following: