Closed ad-moreno closed 4 years ago
Hi @adnio , I would prefer if you re-open the previous PR #262.
I think you should be able to do that.
After force pushing, the commit linked to the PR was lost and I made a new one. In this case I don't know any way to reopen the PR. If you know how to do it please tell me and I will try it.
Thank you
I though you would be able to do it. Anyway it is not a huge problem let's continue with this one.
Thanks for the modifications. You have some cleanup to de before I can merge this.
First you have to rebase your branch on the current master:
$ git pull --rebase https://github.com/AdaCore/Ada_Drivers_Library.git master
You also have to merge all you changes into a single commit.
Thanks
Now it is rebased against the newest commit of the Adacore repository. Please confirm it is OK.
Thank you.
I closed this by mistake
@adnio I changed the base branch for this pull request because community_2018
was deleted after merge.
It looks like it made things worst... Can you try again:
$ git pull --rebase https://github.com/AdaCore/Ada_Drivers_Library.git master
Thanks for your patience, I'm sorry for the erratic workflow...
I rebased it, I think it is OK now. Please tell me if there is something wrong.
Thanks @Fabien-Chouteau
Hi @adnio
No it's still not correct. At this point you might want to backup your code and start from fresh repo.
Regards,
I dind't see any implementation of HAL.UART for nrf51 so I made a simple one based on the datasheet.
P.D. Sorry I accidentally closed the last pull request.