Correct mistranslation in Madgwick algorithm.

simonjwright commented 7 years ago

modules/madgwick/sensfusion6.adb (Madgwick_Update_Q(2)): Correct the calculation of S2. Several spelling corrections in comments.

Fixes #3

Fabien-Chouteau commented 7 years ago

Thanks Simon,

As I said for your pull-request on the Ada_Drivers_Library, we are in the process of (re-)defining contribution procedures so I will hold this PR for now.

I'll let you know when we are ready.

Fabien-Chouteau commented 7 years ago

Hello Simon,

Why did you close this pull-request?

Regards,

simonjwright commented 7 years ago

Fabien,

I’m not sure that I did explicitly close the pull request. Perhaps it got closed because I deleted the branch; which I did because I realised that the commit comment was wrong (it’s actually the calculation of S1, not S2) and my botched use of rebase, together with intermediate commits from your side, meant that I couldn’t fix things without deleting the branch & re-applying the patch.

I think the fact I was suffering from a heavy cold meant I completely forgot about the outstanding pull request. Sorry about that. Memo to self: don’t push commits if you have a cold.

Should I open a new pull request referring the new version of the branch with my changes?

--S

PS I’m confused by the automatic comment above on 11 December, and why your and Pat’s commits got added to this pull request!

AdaCore / Certyflie

Correct mistranslation in Madgwick algorithm. #4