jklmnn
commented
1 year ago The code looks good to me now! +1 It might make sense to clean up the git commits. IMHO it is not necessary to have 23 commits (including several "Fix something...") for this refactoring.
I squashed some of the small commits although I don't want to overdo it as even the small commits introduced merge conflicts that can be a source of errors.
I had to restructure not only the tests but also some support code to avoid code duplication. While I was able to fix much of the missing coverage by writing additional tests or removing unused code some tests (especially those checking for raised exceptions) have the inherent property that the uncovered branch is a test failure. So I couldn't completely avoid ignoring uncovered branched. However this only affects exit branched and the line coverage should not be affected.
Closes #1190