search

AdaCore / ada_language_server

Server implementing the Microsoft Language Protocol for Ada and SPARK
GNU General Public License v3.0
230 stars 54 forks source link

Formatting issues #1149

Closed JHag6694 closed 1 year ago

JHag6694 commented 1 year ago

Hello

Here are 3 small formatting issues I am facing with ALS 23.0.18 (and older releases too) Source code and project settings to reproduce the issue: https://github.com/JHag6694/AdaTest

1 : Adding a pragma Obsolescent to 1 procedure triggers the package to be displayed as striked

2 : Format selection on a single comment line deletes 2 trailing characters

3 : Adding a comment between begin and case make the case instruction to be right-shifted

Issue 1: image

Issue 2: Animation3

Issue3: Animation3

reznikmm commented 1 year ago

Thank you for the report. Good news is that issue 1 has been fixed already and will be in 23.0.19

JHag6694 commented 1 year ago

VScode updated with 23.0.19 today, and issue #1 does not seem to be fixed. Did I miss something !?

reznikmm commented 1 year ago

Indeed :( We will investigate this again. Meantime you can use this:

package Messages is

   procedure Hello_World
     with Obsolescent;

end Messages;
reznikmm commented 1 year ago

I'm closing this as it works with current development version. It works in the release 24.0.1.

JHag6694 commented 11 months ago

Hello @reznikmm,

FYI, according to my tests, issues 2 and 3 of my first message are not fixed in 24.0.1. Did I miss something? Maybe you prefer a specific GitHub issue for each one. Just let me know.