Project file loaded too late

AdaCore / ada_language_server

Server implementing the Microsoft Language Protocol for Ada and SPARK

GNU General Public License v3.0

226 stars 54 forks source link

Project file loaded too late #1189

Closed PaulCayard closed 2 months ago

PaulCayard commented 3 months ago

Hi, when I launch vscode (or I launch command "Developer: Reload Window"):

if a source file is open in the editor, the following problem is displayed: "No project found in root directory. Please create a project file and add it to the configuration.". (FAIL)
if editor is empty or a non-ada file (for example "settings.json") is open in the editor, problem is not arisen. (CORRECT)

Anyway, when the problem occurs, project file is correctly loaded and all works fine, except for the error displayed. It seems that vscode try to parse the first source file (that is displayed in the editor window) BEFORE the loading of the project file.

AnthonyLeonardoGracio commented 3 months ago

Hello @PaulCayard,

I can't reproduce with the latest version (20.0.4) on a simple project. Would you be able to fill a reproducer? That would help us.

Regards,

PaulCayard commented 3 months ago

Hi, thanks for the quick reply. Unfortunately, I wasn't able to reproduce it on open source projects. I can't share the project where problem occurs... How can I help you?

AnthonyLeonardoGracio commented 3 months ago

I can reproduce on one project, even without having an opened file. it's really weird, not sure what's happening since everything works fine right after... We'll investigate.

PaulCayard commented 2 months ago

I've just installed v24.0.5 and problem seems fixed. Is it a coincidence or did you work on it? Thanks anyway!

AnthonyLeonardoGracio commented 2 months ago

Hello,

We have changed the way we display messages related to project-loading: we now emit proper LSP diagnostics. I think the fix comes from that work.

Closing the issue them. Thanks for letting us know!