AdaCore / ada_language_server

Server implementing the Microsoft Language Protocol for Ada and SPARK
GNU General Public License v3.0
235 stars 55 forks source link

Indentation problem on function call #690

Closed carloxff closed 1 year ago

carloxff commented 3 years ago

Hi,

If we have a function call like this

V_RESULT :=
  F_FUNCTION
    (V_PARAM_1 => 2.0,
     V_PARAM_2 => 4.0,
     V_PARAM_3 => 5.0);

Now, we add an extra indentation for the whole block (select + tab). The result is:

  V_RESULT :=
    F_FUNCTION
      (V_PARAM_1 => 2.0,
      V_PARAM_2 => 4.0,
      V_PARAM_3 => 5.0);

The second and subsequent parameters are aligned with the parenthesis, instead of with the first parameter.

Greetings!

petacreepers23 commented 3 years ago

Hello.

I have the same coding style as @carloxff described. It would be nice to know if this is configurable.

Thanks.

AnthonyLeonardoGracio commented 1 year ago

Hello @carloxff,

Could you please share your .gpr Pretty_Printer settings? (i.e: the options that are passed to the formatter)

Also, which IDE are you using?

Regards,

carloxff commented 1 year ago

Hello,

I have no Pretty_Printer setting in the gpr file and no specific options are passed to the formatter.

I'm using the extension in Visual Studio Code.

Thanks for your help.

Regards, Carlos.

El mar, 16 may 2023 a las 16:01, Anthony Leonardo Gracio (< @.***>) escribió:

Hello @carloxff https://github.com/carloxff,

Could you please share your .gpr Pretty_Printer settings? (i.e: the options that are passed to the formatter)

Also, which IDE are you using?

Regards,

— Reply to this email directly, view it on GitHub https://github.com/AdaCore/ada_language_server/issues/690#issuecomment-1549738388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT67ZV5MBL45PJPVNZC5ULDXGOCBVANCNFSM44GSBHPA . You are receiving this because you were mentioned.Message ID: @.***>

AnthonyLeonardoGracio commented 1 year ago
```ada
V_RESULT :=
  F_FUNCTION
    (V_PARAM_1 => 2.0,
     V_PARAM_2 => 4.0,
     V_PARAM_3 => 5.0);

Ok, thanks for the info.

Note that pressing tab does not use the Ada Language Server formatter: it will let VS Code ident the code itself, without executing the textDocument/formatting LSP request. To use our formatter your should execute the Format Selection command instead (Ctrl+K Ctrl+F by default in VS Code).

By using Format Selection and having the proper settings in your .gpr file, you will get what you want.

Regards,