search

AdaCore / bb-runtimes

Source repository for the GNAT Bare Metal BSPs
Other
65 stars 51 forks source link

arm/cortexm.py Support for Python version below 3.9. #62

Closed python36 closed 1 year ago

python36 commented 2 years ago

Method str.removesuffix was added in Python 3.9. Tested on python 3.8. Without these changes, the script raise with the next text:

it__
    base_name = name.removesuffix('-smp')
AttributeError: 'str' object has no attribute 'removesuffix'
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Fabien-Chouteau commented 1 year ago

Hello @python36, we consider Python 3.9 as a requirement for the repository and we are not looking to be backwards compatible at this point.

python36 commented 1 year ago

Hi @Fabien-Chouteau , сan I create a PR with Python version checks added at the beginning of scripts? Is Ada_Drivers_Library also dependent on version Python 3.9?

Fabien-Chouteau commented 1 year ago

Thanks but we don't add this kind of checks.

I don't know if Ada Drivers Library has a strong dependency on a specific Python3 version.

python36 commented 1 year ago

Hi @Fabien-Chouteau. When I tried to run the script with Python 3.8 an error occurred. I was able to resolve this problem, but another user might just think it's a script problem since there's no mention of a Python version dependency anywhere. Therefore, I recommend freezing the Python version and adding checks to scripts and writing dependency in the description, which will greatly facilitate the work of new users. Thanks