search

AdaCore / e3-core

Core framework for developing portable automated build systems
26 stars 36 forks source link

Amend anod primitive signature #602

Closed grouigrokon closed 1 year ago

grouigrokon commented 1 year ago

Three commits here. The first is for linter warning removal. Second is for english typos. Last but not least is the real work.

As the post parameter of the primitives were not called, I added calls to the post function. Hope this does not break anything ...

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

grouigrokon commented 1 year ago

As for why I did that, it's just that, diving in the anod files, I had warnings that the type passed to post was wrong. I asked @Nikokrock who said having str | None would be enough. I kept the Callable part for backward compatibility. If it's about to be removed ... well, no problem :) It was a way for me to go deeper in the processes and code :)

grouigrokon commented 1 year ago

As per this comment, this PR is rejected.