AdaCore / e3-core

Core framework for developing portable automated build systems
26 stars 36 forks source link

Fix e3-pypi-closure name comparison #727

Closed leocardao closed 3 months ago

leocardao commented 3 months ago

Before this patch, if you had a requirement like 'Django==2.2', the version constraint would be ignored because the code was trying to compare 'Django' == 'django'

Now we don't have to worry about character case in this comparison, which corrects the problem.

Nikokrock commented 3 months ago

isn't canonicalize_name enough ?

leocardao commented 3 months ago

isn't canonicalize_name enough ?

@Nikokrock Visibly not, because for django, we end up comparing ‘Django’ != ‘django’, which is true, and so we enter this ‘if’, and, as a result, it ignores the constraint.

This is self.name that have "Django" as a value

Nikokrock commented 3 months ago

Call canonalize on self.name ?

leocardao commented 3 months ago

Call canonalize on self.name ?

Done :)