Provide specific external for library type.

AdaCore / gprbuild

GPRbuild is an advanced build system designed to help automate the construction of multi-language systems.

Other

65 stars 21 forks source link

Provide specific external for library type. #142

Closed simonjwright closed 2 months ago

simonjwright commented 1 year ago

gpr/gpr.gpr (Gnat_Lib_Type): new external GPR_LIBRARY_TYPE, acts as the default for LIBRARY_TYPE.

CLAassistant commented 1 year ago

All committers have signed the CLA.

t-14 commented 1 year ago

Can you clarify what are you trying to do here? Creating the deputy environment variable at the point of the build project doesn't seem to make much sense, and once the project is gprinstall-ed it will get the env variable pair automatically...

simonjwright commented 1 year ago

To avoid name collision for scenario variables, as in AdaCore/gpr@fb04bce.

I had thought this was a general change adopted by AdaCore, but I see it’s not (the equivalent is in at least the langkit_support, libadalang and gpr2 project files).

Found the issue building gnatdoc under Alire (I ended up just setting LIBRARY_TYPE to relocatable).

t-14 commented 1 year ago

But you aren't avoiding name collision. Your primary env variable is still LIBRARY_TYPE. The patch that you mention does it in the opposite order.

simonjwright commented 2 months ago

Closing, because actually implemented in 5790e77.