search

AdaCore / langkit-query-language

query language for Libadalang and Langkit
Other
3 stars 6 forks source link

Rename String_Set to Unbounded_Text_Set #32

Closed leogermond closed 3 years ago

leogermond commented 3 years ago

Following #31 review, the String_Set is not aptly named as it has no Strings as Elements, but instead Unbounded_Text, which are close enough but are, as their name say, unbounded.

This PR aims to make code more transparent on that side, though I'm wondering if the name is not becoming too verbose then?

raph-amiard commented 3 years ago

I'm not convinced of the value this brings on second thought. String_Set is a much clearer name as to what the set actually does, and is much shorter.

leogermond commented 3 years ago

We'll see...