Use gnatcoll_gmp static library

AdaCore / langkit

Language creation framework.

https://www.adacore.com

Other

78 stars 35 forks source link

Use gnatcoll_gmp static library #614

Closed atupone closed 2 years ago

atupone commented 2 years ago

If gnatcoll_gmp has been built supporting static & relocatable libraries, it uses relocatable, and test fails when mixing static and relocatable libraries

CLAassistant commented 2 years ago

All committers have signed the CLA.

atupone commented 2 years ago

There is still other similar problems for not telling gprbuild about using relocatable or static libraries on this other tests:

testsuite/tests/langkit_support
testsuite/tests/adalog
testsuite/tests/misc/link_two_libs

pmderodat commented 2 years ago

Hello,

We can’t reproduce any problem like that. The project file for gnatcoll-gmp from sources (https://github.com/AdaCore/gnatcoll-bindings/blob/master/gmp/gnatcoll_gmp.gpr#L36) uses the LIBRARY_TYPE variable name, and so does the installed project (https://github.com/AdaCore/gnatcoll-bindings/blob/master/gmp/setup.py#L56), so the current GPRbuild arguments passing should be fine. Actually, nowadays both XML/Ada and LibGPR use the LIBRARY_TYPE name, so we could get rid of both the GPR_BUILD and XMLADA_BUILD ones.

Could you clarify where the GNATCOLL_GMP_BUILD name comes from in your setup?

atupone commented 2 years ago

OK, I had to specify --build-var=LIBRARY_TYPE to gprinstall gnatcoll-bindings. GNATCOLL_GMP_BUILD was just the default as in the manual for build-var :

Specify the name of the build variable in the installed project. If this options is not used, the default build variable used is <PROJECT_NAME>_BUILD.

No need to apply this pull request, so. But need to take care of the others as the problem still exist for the gprbuild call that do not specify the LIBRARY_TYPE to use.