AdaCore / libadalang-tools

Libadalang-based tools
GNU General Public License v3.0
16 stars 13 forks source link

Makefile issues #14

Open simonjwright opened 4 years ago

simonjwright commented 4 years ago

The Makefile says LIBRARY_TYPE ?= static, but when I run it against installed libraries I get

==============Messages for file: /usr/local/share/gpr/libadalang.gpr
    16.    BUILD : BUILD_KIND := external("LIBADALANG_LIBRARY_TYPE", external("LIBRARY_TYPE", "relocatable"));
           |
        >>> value "static" is illegal for typed string "build"

==============Messages for file: /usr/local/share/gpr/langkit_support.gpr
    14.    BUILD : BUILD_KIND := external("LANGKIT_SUPPORT_LIBRARY_TYPE", external("LIBRARY_TYPE", "relocatable"));
           |
        >>> value "static" is illegal for typed string "build"
gprbuild: "src/build.gpr" processing failed

This may, of course, be a failure on my part to install those libraries with all the library types- what’s expected?

Also, the install-strip target can strip the whole of the target bin/ directory, which would be rude if that directory was a public one, e.g. /usr/local/bin. Could there be a plain install target that doesn’t strip? (and why strip, anyway?)

simonjwright commented 1 year ago

I don’t know what df37ad9 fixed, but it didn’t fix either of the problems raised in this issue.

Fabien-Chouteau commented 1 year ago

Sorry Simon, this issue was closed by mistake.