AdaCore / libadalang

Ada semantic analysis library.
https://www.adacore.com
Other
147 stars 42 forks source link

name_resolution/field_hiding_2 test failure with GNAT 22.2 #954

Closed LordAro closed 1 year ago

LordAro commented 1 year ago
INFO     FAIL            name_resolution__field_hiding_2: unexpected output
Diff failure: unexpected output
--- expected
+++ output
@@ -27,3 +27,3 @@
 Expr: <CallExpr test.adb:25:10-25:33>
-  references:    <DefiningName a-textio.ads:566:14-566:22>
+  references:    <DefiningName a-textio.ads:507:14-507:22>
   type:          None
@@ -31,3 +31,3 @@
 Expr: <Id "Put_Line" test.adb:25:10-25:18>
-  references:    <DefiningName a-textio.ads:566:14-566:22>
+  references:    <DefiningName a-textio.ads:507:14-507:22>
   type:          None

Presumably just because the contents of a-textio.ads is different with GNAT (Alire) 2022, or whatever you're testing with in your libadalang gitlab image?

Would be nice for it to be slightly less dependent on the compiler version...

pmderodat commented 1 year ago

Hello,

Your conclusion is correct. We try not to make test outputs depend on the compiler that is used, here it is an oversight from us when writing this testcase. We’ll fix it, thank you for reporting it!

pmderodat commented 1 year ago

This should now be fixed, thanks again for reporting this!