search

AdaCore / uwrap

1 stars 0 forks source link

Adding style checks/warnings #2

Closed raph-amiard closed 4 years ago

raph-amiard commented 4 years ago

In the spirit of making uwrap up to speed in terms of QA/testing, we should enable the gnat style checks & warnings on the codebase.

After some testing, I determined that using gnatpp for the style checks should get us 80% here. However, there are a lot of warnings, including ones that should be disabled/silenced. I think we should do our best to enable -gnatwae in dev mode and use Warnings (Off) when necessary.

@QuentinOchem if you want I can take care of the style ones, but I'd prefer if you handle the warnings!

QuentinOchem commented 4 years ago

@raph-amiard I absolutely agree. It's time to move the project from experimental to prod. I also have on the pipe the need for subprogram documentation.

Happy to take the warnings :-)