search

AdaRoseCannon / handy-work

Framework Agnostic Hand tracking for WebXR
https://aframe-xr-starterkit.glitch.me/
MIT License
94 stars 11 forks source link

Update handy-controls.js #20

Open addy1997 opened 1 year ago

addy1997 commented 1 year ago

changed the getJointPoses() with fillPoses() and fillJointRadii() methods as mentioned in the issue (#18)

addy1997 commented 1 year ago

Hi @vincentfretin,

Thanks for your reply but I thought that changing the getJointPose() method with suffice because Ada's component uses inputSource API as opposed to the hand-tracking-controls component.

However, I replaced controller.hand.values() with inputSource.hand.values(). Do I need to add anything else to the code?

vincentfretin commented 1 year ago

Did you test it? this.jointPoses is not defined.

addy1997 commented 1 year ago

Did you test it? this.jointPoses is not defined.

Thanks for pointing that out. Yes, this is a silly mistake. this.jointPoses and this.jointRadii will obviously be not defined because this. is not needed at all since I am using the variables in the same function they are defined.