search

AdaSupport / ios-sdk

EmbedFramework is a small iOS SDK that is used to embed the Ada Chat bot into native iOS applications.
MIT License
4 stars 20 forks source link

Swift Package Manager Support #26

Open Coledunsby opened 3 years ago

Coledunsby commented 3 years ago

It would be great if we could import this dependency via SPM!

daniel-k-marks-zz commented 2 years ago

Any update on this?

philviso-reverb commented 2 years ago

Any update on this?

mccarron commented 2 years ago

I would really love for this to get implemented as it's one of our last Cocoapods in our project.

kzyryanov commented 2 years ago

Would be great to have SPM support! Please add it!

ailynempower commented 2 years ago

Would be great to have SPM support!

Or, at the very least, have the framework support iOS simulators, as listed in this other issue. Module 'AdaEmbedFramework' was created for incompatible target arm64-apple-ios10.0-simulator:

lujcheng commented 2 years ago

@empowerMax it looks like we have this issue in our backlog, I'll try to get a timeframe for this

mccarron commented 2 years ago

I wonder if we can get @klundberg to open a PR from their fork with SwiftPM support built in to help it along faster?

klundberg commented 2 years ago

My experiments there were incomplete IIRC, but if anyone's able to take it and run with it, be my guest :)

sergeifabian commented 1 year ago

Any updates?

klundberg commented 1 year ago

I got an itch to finish looking into how this would work, and opened pr #66 (which worked for me when I tried it in an example app). If anyone else wants to try it out, you can look at my spm branch on my fork until it gets merged.

mccarron commented 1 year ago

@klundberg I tested it out and it worked flawlessly. Hopefully someone from Ada will merge this in. I'll reach out to our account rep and hope they can help push it forward.

philviso-reverb commented 1 year ago

Thanks for the work @klundberg!

Our account rep told us that supporting Swift Package Manager is no longer a planned feature and was removed from your backlog. Is the official stance from Ada that if we want to use Swift Package Manager we should use a fork of your repo maintained by a third party?

mccarron commented 1 year ago

That is unfortunate Ada is refusing to support Swift Package Manager. I tried to get them to support it for at least two years, and their refusal to support it is one of many reasons we ended our relationship with them in our App.

Thankfully @klundberg's fork worked great and they should just hire them to get official support added.