Some improvements

[igarrido-adalab]

Really cool job @INDRAKL !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• [x] If you call getRandomNumber function inside the event callback, you will be creating a new random number every time the user clicks the button. That makes the game really difficult to play and the hints will have different results. Let's generate the random number when the page loads and starts the game.
• [x] Don't use a event method outside the handler function https://github.com/Adalab/modulo-2-evaluacion-intermedia-INDRAKL/blob/eb8639301e70d4274aa2c3b5445d57230bd1b04d/js/main.js#L18
• [x] When you are using event.preventDefault() you must declare the event parameter in the funcion.
• [ ] Watch out for constant names used to save DOM references... Do we want to use the DOM reference or that DOM element content (innerHTML/value)? (i.e. textTry or attemps)

JavaScript: advanced

• [x] Move your line that increments the counter of clicks into updateScore https://github.com/Adalab/modulo-2-evaluacion-intermedia-INDRAKL/blob/eb8639301e70d4274aa2c3b5445d57230bd1b04d/js/main.js#L25.
• [x] You are writing many times "clueEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'clueEl'?

Good practices

• [x] Try to improve your commit messages, better in English and using imperative.

Structure

• [x] CSS and JS path must to start with ./.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Add a reset button that cleans the tries counter, generates a new random number and writes the initial feedback (let the user reset the game instead doing it automatically with a setTimeout).
• Show the restart game button when the game is over and hide the test button.
• Complete the code needed for the restart game button.
• Add a limit for the numbre of tries. If the user reaches that limit, the page announces that "The game is over".
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

From now on you can commit your changes to the main branch of your project. Do not close this issue until your teacher asks you to

[INDRAKL]

Gracias por los comentarios. ¿A qué te refieres con este issue Watch out for constant names used to save DOM references... Do we want to use the DOM reference or that DOM element content (innerHTML/value)? (i.e. textTry or attemps)? Mil gracias

[igarrido-adalab]

Creo que ya lo hablamos en persona, pero lo dejo aquí por escrito: Me refiero a que los nombres de las variables no sean susceptibles de confundir lo que contienen. Por ejemplo, la variable attempts parece que puede almacenar el número de intentos pero en realidad tiene el elemento del HTML de la página que muestra a la usuaria los intentos. Un nombre mejor sería attemptsParagraph