Improvements

[migueldelmazo]

Really cool job @JuliaMersing !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• [ ] Type two condition in this if for checking if number is lower than 1: https://github.com/Adalab/modulo-2-evaluacion-intermedia-JuliaMersing/blob/master/main.js#L22
• [x] Use ONE addEventListener for each event. If you need to execute multiple functions at once perhaps you can call them inside your unique handler.

JavaScript: advanced

• [ ] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?

Good practices

• [x] Indent and avoid extra white spaces to improve readability and prevent bugs. Configurate code formatter in VS Code!!!
• [ ] These inputs must be paragraph: https://github.com/Adalab/modulo-2-evaluacion-intermedia-JuliaMersing/blob/master/index.html#L22-L29

Structure

• [x] Define a good structure of folders and files for the project.

HTML

• [x] Add form
• [x] Add HTML elements for the game: title, label, input, button, space for feedback (div, p) and number of trials.
• [x] Use a label to define the content of the input.
• [x] Connect the label to the input using the for attribute of the label and the id of the input.
• [x] Use placeholder attribute instead of value one to show a field's hint.
• [x] Use placeholder.
• [x] Inputs must have a type attribute set to a valid value (text, number, mail, button..).
• [x] Don't add an empty attribute for no special reason: by adding an empty value attribute we are indeed setting it to a certain (empty) value, do we want to do that?

Let me know if you have any doubts ;)

Go for it!!

Do not close this issue until your teacher asks you to

[JuliaMersing]

Los que no he resuelto es porque no he entendido que tenía que hacer. Hay muchos que creo que estaban ya hechos, si no es así, por favor házmelo saber. Gracias

[migueldelmazo]

Hola @JuliaMersing,

• [ ] Type two condition in this if for checking if number is lower than 1: https://github.com/Adalab/modulo-2-evaluacion-intermedia-JuliaMersing/blob/master/main.js#L22: me refiero a que solo estás comprobando si es mayor de 100 pero no menor de 1. Haz una doble condición dentro del if.
• [ ] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?: En esta función estamos repitiendo imputClueElement.value muchas veces. Es más elegante sacarlo a una función que se llame por ejmplo function updateClue() a la que pasamos por parámetros el texto con el que queremos actualizar la pista.
• [ ] These inputs must be paragraph: https://github.com/Adalab/modulo-2-evaluacion-intermedia-JuliaMersing/blob/master/index.html#L26-L44: estos dos elementos no deben ser inputs porque el usuario no va a introducir nada en ellos. Preferimos que sean un párrafo, ya que los vas a actualizar tú desde JS.

Un saludo.