Some improvements

[ytaylor]

Really cool job @ruadaslucia !!!

Here you have some tips to improve the exercise:

JavaScript: basic and logic

• [x] Execute getRandomNumber() function when the user clicks on "Jugar" button.
• [x] If you call getRandomNumber() function outside the event callback, you will be creating a new random number when the page loads. That makes the game really simple and the hints will have the same result. Let's generate the random number when the user clicks on "Jugar" button and starts the round: https://github.com/Adalab/modulo-2-evaluacion-intermedia-ruadaslucia/blob/fcbb99a9dc61bd281c0755660f832b3f65a3f8a0/js/main.js#L17
• [x] Fix the if's structure: check for one option, then the other and then for the rest is enough with an else statement.
• [x] The variable leftover stores an HTML element, you cannot do a math operation on an HTML element. This is the reason that on the page you get the money in NaN: https://github.com/Adalab/modulo-2-evaluacion-intermedia-ruadaslucia/blob/fcbb99a9dc61bd281c0755660f832b3f65a3f8a0/js/main.js#L53
• [x] Remove debugger and other unnecessary code: https://github.com/Adalab/modulo-2-evaluacion-intermedia-ruadaslucia/blob/fcbb99a9dc61bd281c0755660f832b3f65a3f8a0/js/main.js#L24

JavaScript: advanced

• [x] Check if the <select> has the default option (with no value).
• [x] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?
• [x] Use ev.preventDefault() to prevent page reload.

HTML

• [x] Don't leave attributes with empty value: https://github.com/Adalab/modulo-2-evaluacion-intermedia-ruadaslucia/blob/fcbb99a9dc61bd281c0755660f832b3f65a3f8a0/index.html#L18

CSS

• [x] Avoid adding styles until the js code is solid as a rock.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Check if the player has enough money to bet and if the bet is greater than 0 and lower than the current amount of the player.
• Add a reset button that cleans the select, balance of money and writes the initial feedback.
• Show the restart game button when the game is over and hide the play button.
• Complete the code needed for the restart game button.
• Validates if the balance of money is available is less than the money bet and displays a message
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

Do not close this issue until your teacher asks you to

[ruadaslucia]

Hi, i have made the changes you asked of me. Please, only if you have the time to review it , maybe you can give me some feedback on them. Thank you : )