search

Adam- / runelite-plugins

16 stars 37 forks source link

Add detached camera hotkey #57

Closed SystemsOnline closed 1 year ago

SystemsOnline commented 1 year ago

Hi Adam,

This pull request adds a configurable hotkey that toggles the detached camera state on/off. detached-camera-hotkey-config

I enjoy fashionscaping and taking screenshots around the game as I play - the plugin is already amazing for doing that but it can be annoying (especially in resizable modes) to have to open up the sidebar, toggle the plugin off and then on again, and re-close the sidebar. A hotkey, which is off by default, makes the task easier. I believe this will also close #8

This is my first time making a change to a plugin so please let me know if this looks good or if you'd like something to change about it. Thank you in advance!

Adam- commented 1 year ago

You should use a HotkeyListener instead of writing your own KeyListener impl

SystemsOnline commented 1 year ago

I didn't know that existed, thanks! Changed in 3f60cd9, is this what you're looking for?

SystemsOnline commented 1 year ago

Thank you for merging! Do you know if there's anything else I need to do to have the change show up in runelite?

SystemsOnline commented 1 year ago

@Adam- quick heads up, I submitted a pull request against the plugin hub to update the version: https://github.com/runelite/plugin-hub/pull/3758

Adam- commented 1 year ago

I've pushed an update with this