Adam- / runelite-plugins

16 stars 37 forks source link

Disable key remapping when detached camera mode is active? #61

Open SystemsOnline opened 1 year ago

SystemsOnline commented 1 year ago

Hi Adam, thank you again for the great plugin and for helping me with #57. I'm back with another idea, though this time I'm less sure of how to implement it, or if you're receptive to the idea or not. Here is my pitch:

Both the detached camera and key remapping plugin's default config rely on WASD keys for camera movement, with key remapping taking priority unless you're currently chatting (ie, no Press Enter to chat... message). I use both plugins, meaning every time I enter detached mode, I have to remember to press the enter key as well, otherwise I can't move the focus point around.

I've tested, and this isn't an issue if there isn't any overlap in keys between the two configs, but I quite like how convenient the WASD keys are for remapping purposes - I don't use them for normal camera movements but I do use them for other tabs.

Could we add a config checkbox to allow users the option to disable key remapping while the camera is detached?

This does mean the detached camera would have to know about the key remapping plugin. I'm not sure how you feel about such an integration, but it made the most sense to me to open the discussion here, since detached camera is a plugin-hub plugin rather than included by default. Thoughts?

Thanks in advance -

SystemsOnline commented 1 year ago

Ping @Adam-

Did you get a chance to look over this suggestion?