Adam-Kay / Batch-Encoder

Command line batch file encoder using FFmpeg
GNU General Public License v3.0
0 stars 0 forks source link

Program should be able to download FFmpeg #25

Open Adam-Kay opened 11 months ago

Adam-Kay commented 11 months ago

Improvement Description

Most people do not know what FFmpeg is, nor want to figure out how to download it. Perhaps the program could install it for the user, and from then on it would be in PATH as suggested in #4 , and then doesn't have to be worried about again.

How to implement

Three stage option:

Preferred option

  1. Attempt to install with winget - do "essentials" install if possible (Make sure to warn user about Microsoft Agreement that might pop up)

    If preferred fails (WinGet is not available on device OR user declined agreement OR \<other>)

  2. 'Manual' install using https://www.gyan.dev/ffmpeg/builds/ffmpeg-release-essentials.zip and PowerShell's Expand-Archive utility.

    If all else fails

  3. Search for ffmpeg.exe in current folder (#3) and if it doesn't exist, ask user for path to ffmpeg.exe (current behavior).
Adam-Kay commented 11 months ago

(Make sure to warn user about Microsoft Agreement that might pop up)

Screenshots of WinGet agreement in virtual machine

Initial agreement

Initial Agreement

Declined agreement and error code (%ERRORLEVEL%)

Declined agreement and error code

Accepted agreement and error code (or lack thereof)

Accepted agreement and error code

Adam-Kay commented 11 months ago

With the following now completed, a more lightweight FFmpeg Essentials package can be grabbed from WinGet instead:

Adam-Kay commented 11 months ago
Adam-Kay commented 10 months ago

Just thought that I can also use where winget to see if the machine has winget installed. If not, it can skip directly over to secondary