search

Adam-Kay / Batch-Encoder

Command line batch file encoder using FFmpeg
GNU General Public License v3.0
0 stars 0 forks source link

Program exits in rare cases where updater fails #31

Closed Adam-Kay closed 11 months ago

Adam-Kay commented 11 months ago

Bug Description

When using b-e updater.bat, in the event the curl request fails during the acquisition of the main program file (in this case due to MITM on corporate networks), the program will gleefully continue and cause itself to shut down

Steps to Reproduce

  1. Use b-e updater.bat on a corporate network
  2. Download will proceed
  3. Program shows "Download complete. The program will now clean up and restart."
  4. The program cleans up and then exits, as the download has not really completed due to the curl request failing (error 0x80092012, revocation unable to check for certificate)

Expected behavior

Download should complete and program should restart as usual

Potential Cause

2 fixes to put in place:

  1. Perform additional checks to ensure existence of downloaded file before attempting to restart
  2. In case of failure, re-attempt download but with --ssl-no-revoke flag in curl request
    • if that fails also, take the program to :AutoUpdateError.
Adam-Kay commented 11 months ago

This likely also happens with batch encoder.bat due to the nature of the problem

Adam-Kay commented 11 months ago
Adam-Kay commented 11 months ago
About to be completed. End result: Standard Operation First fail (MITM etc.) Second Fail
image image image