search

Adam-Langley / pybleno

A direct port of the Bleno bluetooth LE peripheral role library to Python2/3
MIT License
68 stars 34 forks source link

Replacing null with None for Python codebase #24

Closed vinitatgithub closed 5 years ago

vinitatgithub commented 5 years ago

In Characteristic.py -> onUnsubscribe method, there is usage of null which is not defined in Python. This might have been stale code from original NodeJS library. Replacing null with None which is defined in Python and is equivalent in the functionality.

Adam-Langley commented 5 years ago

Thanks @vinitatgithub - good catch. I see there are several references to "null" in the code-base. Could you please clean them up in your fork also, and I can bring them all into the merge in one go. (don't worry about commented-out code).

Thanks.

vinitatgithub commented 5 years ago

Not a problem. Done. :)