Adam-Langley / pybleno

A direct port of the Bleno bluetooth LE peripheral role library to Python2/3
MIT License
68 stars 34 forks source link

Fix handle value confirmation (on Indicate characteristics) #28

Closed mh- closed 5 years ago

mh- commented 5 years ago

There's a typo in Gatt.py that causes a Handle Value Confirmation to trigger an Error Response. This means that there are always errors sent back when an Indicate characteristic is used.

Adam-Langley commented 5 years ago

Hi @mh- Thanks for the fix, and suggestion. WRT the typo fix, I've merged your other PR. Can you make your 'Complete Local Name' suggestion against Bleno? https://github.com/noble/bleno/issues/347

If you can get that pulled to Bleno, we can reflect this in Pybleno - I'm just not keen at this point to diverge the behavior of Bleno/Pybleno.