search

Adam-it / cli-for-microsoft-365-extension

This extension provides functionalities that may be helpful when creating scripts using CLI for Microsoft 365.
https://marketplace.visualstudio.com/items?itemName=adamwojcikit.cli-for-microsoft-365-extension
MIT License
3 stars 0 forks source link

🐞 [Bug] : Error in creating new tab in editor with prefilled Microsoft 365 CLI Script #67

Closed Saurabh7019 closed 1 year ago

Saurabh7019 commented 1 year ago

📝 Describe the bug

Error occurs when selecting a script in CLI for Microsoft 365 VS Code Extension samples: 'Error while creating script file based on sample.

👣 Steps To Reproduce

Steps to reproduce the behavior:

  1. Open the CLI for Microsoft 365 extension in Visual Studio Code.
  2. Select the "CLI for Microsoft 365 Samples" option.
  3. Click on the "Script" button on a sample tile.

📜 Expected behavior

A new tab should open in Visual Studio Code, and the corresponding script should load within that tab.

📷 Screenshots

image

💻 Desktop (please complete the following information):

Adam-it commented 1 year ago

@Saurabh7019 thanks for the feedback. I already know what is the issue, since in CLI for M365 we migrated docs from mkdocs do docusource and there is a slightly different format in the way we now store samples. As the extensions just 'cuts out' the script from sample file from the repo probably the way I split the sample is currently not valid anymore.

So additional info is that this bug will only happen for script samples coming from CLI repo bit from PnP script samples repo (that's why probably I did not notice it during testing 🤦‍♂️)

I planned to spend some time today on this extensions so I will look into this bug ASAP. 👍

Saurabh7019 commented 1 year ago

No rush! I just wanted to bring it to your attention.

Adam-it commented 1 year ago

@Saurabh7019 BTW, I know it's not part of this issue so if you want we could move this to some different chat or any other place, but from the screen shoot I noticed you also have the Viva Connections Toolkit 👀. TBH I am looking for some feedback on this extension and I was wondering if you would be so kind and maybe you could share some comments or observations about this extension? Do you see something lacking or not useful? Any kind of feedback will be helpful ♥️

Saurabh7019 commented 1 year ago

Absolutely! I would be happy to thoroughly explore the extension and provide you with my observations and any suggestions for improvement.

Adam-it commented 1 year ago

Absolutely! I would be happy to thoroughly explore the extension and provide you with my observations and any suggestions for improvement.

Thanks, you rock 🤩. Reach me out or open an issue on the Viva vs code extension 👍. I will keep an eye out for your feedback