search

Adam42 / pull-tabs

Browser extension to manage tabs either in bulk or per-tab
https://adam42.github.io/pull-tabs/
Other
7 stars 0 forks source link

cannot get verified with pocket #34

Closed januario-hh closed 5 years ago

januario-hh commented 6 years ago

I cannot configure and thus not use at all this extension, because I cannot use the link "you are not authorized, please sign in" (under Services > Pocket). Clicking on it does nothing.

Adam42 commented 6 years ago

Could you let me know what browser you're using and what version of the extension?

januario-hh commented 6 years ago

the latest Firefox (57.0, 64 bit) and pulltab 0.11.0. I have manually typed the underlying link which can be viewed in the left downward screen corner into the address field and could then access/authorize pocket. Then I could eventually proceed to save the tabs. My acknowledgement: This seems to be really helpful! Thank you! /J.

-----Ursprüngliche Nachricht----- Von: Adam Pieniazek [mailto:notifications@github.com] Gesendet: Donnerstag, 7. Dezember 2017 13:18 An: Adam42/pull-tabs Cc: januario-hh; Author Betreff: Re: [Adam42/pull-tabs] cannot get verified with pocket (#34)

Could you let me know what browser you're using and what version of the extension?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Adam42/pull- tabs/issues/34#issuecomment-349950999 , or mute the thread https://github.com/notifications/unsubscribe- auth/Agv8OSzMqYFMIqfpuo2jmGJwIaq7FfvWks5s99d6gaJpZM4Q5a-m . https://github.com/notifications/beacon/Agv8OSDfMQwl_TyKJQvZHUGKLLHD-c_tks5s99d6gaJpZM4Q5a-m.gif

Adam42 commented 6 years ago

Glad you found a workaround!

When I started the Firefox version of this extension Mozilla did not yet have a version of launchWebAuthFlow https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/identity/launchWebAuthFlow so I had to add custom functionality. Now that launchWebAuthFlow is available in Firefox I'll be updating the extension to use it which should make authenticating to Pocket and other services much less flaky.

Will update this issue when that change makes it into a new release of the extension.

luzb3l commented 5 years ago

I just had the same issue that @januario-hh had, and solved it in the same way: it seems the issue is that Firefox (I'm using version 63.0.3 64bit) prevents the pop-up with the authentication dialog; I rewrote the moz-extension... url and I could then proceed with the authentication.

Adam42 commented 5 years ago

@luzb3l @januario-hh PR #44 should resolve this issue. It's version 0.15.0 in Firefox: https://addons.mozilla.org/en-US/firefox/addon/pull-tabs/versions/