Wildfly image - Githubissues

AdamBien / docklands

Minimalistic Java EE / Jakarta EE / MicroProfile Related Dockerfiles

Apache License 2.0

326 stars 106 forks source link

Wildfly image #7

Open devylon opened 7 years ago

devylon commented 7 years ago

I'm new to docker and just started to experiment with docker. Therefor I used the docklands wildfly image. Starting wildfly with an ENTRYPOINT causes the image to not react on image shutdownhook and the wildfly ist just killed.

From the docker reference:

The shell form prevents any CMD or run command line arguments from being used, but has the disadvantage that your ENTRYPOINT will be started as a subcommand of /bin/sh -c, which does not pass signals. This means that the executable will not be the container’s PID 1 - and will not receive Unix signals - so your executable will not receive a SIGTERM from docker stop .

AdamBien commented 7 years ago

Do you need to gracefully download wildfly? Just killing it is faster :-)

devylon commented 7 years ago

I'm running camel within wildfly. And some of the camel routes need a graceful shutdown.

t1 commented 5 years ago

I really like Adam. He does a great job. But at least for docklands/wildfly I prefer to use the official jboss/wildfly for several reasons:

It's always up-to-date (currently 16.0.0 over 15.0.0).
It uses a stable path /opt/jboss/wildfly/ so I can add deployments without repeating the version number.
It uses a system user (created with -r), which is more secure.
It registers shutdown hooks. And probably there are many more reasons that I just didn't see, yet.

t1 commented 5 years ago

okay, Adam just release an update to 16.0.0, so my first point is obsolete (for now) ;-)