WAR name is not derived properly if the pom contains `finalName` element.

AdamBien / wad

Watch and Deploy - deploying ThinWARs without IDE plugins

http://wad.sh

MIT License

111 stars 24 forks source link

WAR name is not derived properly if the pom contains `finalName` element. #1

Closed rsvoboda closed 5 years ago

rsvoboda commented 5 years ago

Archive name is resolved by String thinWARName = currentDirectory + ".war"; https://github.com/AdamBien/wad/blob/master/src/main/java/wad/App.java#L78

WAR name is not derived properly if the pom contains finalName element.

    <build>
        <finalName>foo-bar</finalName>
    </build>

AdamBien commented 5 years ago

Its intentional -> in ThinWARs the artifact id should be the WAR name. In 99% of all my projects it is the case. I like the convention. Thanks for testing!