search

AdamBrodzinski / meteor-phonegap-oauth

Fixes how Meteor handles OAuth popups on PhoneGap/fullscreen
MIT License
33 stars 7 forks source link

No signup/login with v0.8.1 #4

Closed Aldlevine closed 10 years ago

Aldlevine commented 10 years ago

Looks like some of the later Meteor releases are breaking the login. I'm not having any issues closing the IAB, but once it is closed it doesn't seem to trigger the login. I've traced the change that's causing the issue to this release: https://github.com/meteor/meteor/commit/cb6113170f251d8e679f48c13f434ecd78ddecf9

AdamBrodzinski commented 10 years ago

Ah nuts.... I was afraid of that. They patched an OAuth security hole in that release. Which OAuth service are you using?

@faceyspacey just submitted a pr https://github.com/AdamBrodzinski/meteor-phonegap-oauth/pull/3 that fixes Twitter by going around it a different way.. you might want to try that to see if that branch is not broken. https://github.com/faceyspacey/meteor-phonegap-oauth/commit/54a89728ac1ad1ff898c9eb53726ffde9e3a8ac7

The regex might need tweaked depending on the provider though.

Aldlevine commented 10 years ago

Hmmm, I tried that change with the regex that works for my google oauth, but no luck. In my circumstances, the JS being injected is running, but the callback is never running. Perhaps I don't have an up to date enough version of the InAppBrowser plugin?

AdamBrodzinski commented 10 years ago

Closing. This should be fixed with #5. Feel free to re-open if you're still having issues