search

AdamEssenmacher / GoogleApisForiOSComponents

A community-supported fork of the abandoned Xamarin.iOS.* binding libraries from Microsoft
MIT License
63 stars 13 forks source link

Feature/fix firebase analytics without ad support #38

Closed lassejon closed 2 months ago

lassejon commented 2 months ago

Fixed the path for folders required for enabling the FirebaseWithoutAdIdSupport.

@AdamEssenmacher do I need to change anything else to get this fix out asap?

AdamEssenmacher commented 2 months ago

Thanks for the PR! It looks like this has probably been broken since 8.8 :(

This seems pretty straightforward so I should be able to run and publish a quick build.

Are you running into any specific issues that this fixes? I'd love to understand what problem(s) this was causing.

lassejon commented 2 months ago

Thanks for the PR! It looks like this has probably been broken since 8.8 :(

This seems pretty straightforward so I should be able to run and publish a quick build.

Are you running into any specific issues that this fixes? I'd love to understand what problem(s) this was causing.

The reason why I discovered this was when I was setting the property 'FirebaseWithoutAdIdSupport' to True, the build was failing. Now, in our case it is actually not an issue, because we can just omit the property entirely and it will find the correct folder since the new name is the same as the old one WITH ad support. But it will be a problem if you are expecting the ad support to be enabled.

You can work around it by overriding the target, but I think it makes more sense to have it working as it was intended 😄