AdamEssenmacher / GoogleApisForiOSComponents

A community-supported fork of the abandoned Xamarin.iOS.* binding libraries from Microsoft
MIT License
63 stars 13 forks source link

Fix GoogleAppMeasurement NativeReference correctly in Core.targets #42

Closed Digifais closed 1 month ago

Digifais commented 1 month ago

Looking at the release notes of the Firebase Apple SDK, all the way back to 8.8.0, we can see the following being stated:

Increased minimum required CocoaPods version to 1.10.2 to refactor AdSupport-related code out of GoogleAppMeasurement.xcframework to an optional GoogleAppMeasurementIdentitySupport.xcframework dependency.

GoogleAppMeasurement/WithoutAdIdSupport subspec now ships GoogleAppMeasurement.xcframework. GoogleAppMeasurement/AdIdSupport subspec ships both GoogleAppMeasurement.xcframework and GoogleAppMeasurementIdentitySupport.xcframework.

Here you can clearly see that "WithoutAdIdSupport" only ships GoogleAppMeasurement.xcframework, while "AdIdSupport" is supposed to ship both GoogleAppMeasurement.xcframework AND GoogleAppMeasurementIdentitySupport.xcframework. According to the first paragraph, GoogleAppMeasurement.xcframework is the base framework while GoogleAppMeasurementIdentitySupport.xcframework is meant to be an optional dependency on top of the base framework which cointaints the AdSupport-related code.

This should fix #35 and #40 correctly.