AdamHamstead / Simile-Project-Team-A

The github repo for SHU PROFESSIONAL SOFTWARE PROJECTS Team A Simile Project
0 stars 0 forks source link

Converting code to OOP #17

Closed Alex-Darby04 closed 5 months ago

Alex-Darby04 commented 6 months ago

EDIT: It seems harder to make existing functions into oop than just re-doing a lot of the flow entirely.

From what I can tell the current flow is: CGIF file -> Triples -> Binaries -> check graph and create report -> CXT file

The new flow would be: XML -> Objects -> check graph and create report -> CXT file

Doing it OOP almost entirely removes the need for triples but they should be able to be outputted the same as they store the same data. If i'm misunderstanding someone pls correct me.

Adams XML parser is handling creating the objects so the main goal is basically to check the graph, create the report and CXT file.

Alex-Darby04 commented 6 months ago

Each function needs to be converted to OOP after being written in typeScript.

Please add a comment when you work on a function. Please write the name of the function and your name. Once finished add the date completed by editing the comment.

E.g:

Alex Darby - Input_csv_file Completed: 19/02/2024

Alex-Darby04 commented 6 months ago

Alex Darby - Line 661-732 functions

Dn1San commented 6 months ago

Daniel Mozafari - FindRelationsFindConcepts: Completed 20/02/2024

Dn1San commented 6 months ago

Daniel Mozafari - Output cxt files Completed: 20/02/2024

Alex-Darby04 commented 6 months ago

Not sure we need these functions in the oop version: MakeTriples AddBinaries Triples to Binaries Find Concept, Find Relation (should be handled by search for target?) Some functions in line 661-732

Dn1San commented 6 months ago

Daniel Mozafari - Input csv file

Alex-Darby04 commented 6 months ago

Daniel - working on cxt output - complete (?) Alex - working on report output

Alex-Darby04 commented 5 months ago

Moved to using old version.

OOP version out of scope