search

AdamISZ / CoinSwapCS

Simple implementation of Bitcoin CoinSwap, client-server
GNU General Public License v3.0
31 stars 14 forks source link

Set server-side maximum coinswap amount based on wallet availability #44

Closed AdamISZ closed 7 years ago

AdamISZ commented 7 years ago

Doing it dynamically is a privacy leak. Better: stop accepting coinswaps if balance falls below configured maximum.

AdamISZ commented 7 years ago

First, the basic check already existed in csjson.py, but due to the above comment, it has been changed to the conservative version (status = busy if available < max), with an appropriate comment.

Further, to support dynamic loading, there is now a task.LoopingCall that updates the wallet.unspent list at high frequency (1s for now) to support funding the wallet without restart. (Note the funding must be to an address in the cache, but it will be if a sync ever picked it up. (Worst scenario is only that a client uses independent code to generate addresses and funds something outside the gap limit, it is ignored, but the coins are there anyway).

AdamISZ commented 7 years ago

Implemented as described above in 53c2be85d5b30f9e38d23972f5bef6c93656c2ab.

Done some concurrent user tests, seems correct so far. The unspent monitoring loop is only for the server (real time funding for client during run is not useful).