AdamLearns / Abbott

A bot specifically for the Adam Learns show (Twitch, Discord, etc.).
8 stars 2 forks source link

Update the Web Interface (UI) and add some convenient functionality (UX) #86

Closed shadyan closed 7 months ago

shadyan commented 7 months ago

Describe the pull request

Updated the Web Interface design (UI) for Abbott's commands and added some convenient functionality (UX)

Why

To make the web interface look more roomy (kind of objective) and overall look better (strictly objective subjective)

Also added some convenient keyboard shortcuts

Update: Also added dark mode (default) and a button to change the mode

How

Please read the commit messages for additional details:

Screenshots Dark mode:
image

Light mode:
image

Default light view (before dark mode changes):
image

Limited results (before dark mode changes):
image

No results (before dark mode changes):
image

shadyan commented 7 months ago

Thanks for the feedback @HiDeoo.

I completely realize that many of these changes are a matter of subjective preference, so I don't mind if Adam decides not to use any of what's here for that or any other reason.

Here are some notes on your comments:

AdamLearns commented 7 months ago

Thank you both very much for looking into this (and both of you without me even having to ask!). 🙏 I looked through it and made a small commit. The things I would still probably address are:

HiDeoo: Just quickly looked at the changes after my review, I think it would be nice if everything related to dark mode (markup and JS) would be outside of the index.astro file and be in a dedicated component (and the related JS needs to be in a is:inline script tag to avoid a FOUC)

I'm going to merge this for now though so that the PRs can stay small.

(also, I should probably standardize on the formatting used so that I don't keep modifying it with my changes 😳)