AdamMoses-GitHub / MMM-ImageSlideshow

Displays images one-at-a-time from local folders.
MIT License
43 stars 24 forks source link

Instructions For Newbies #10

Open OneOfTheInfiniteMonkeys opened 6 years ago

OneOfTheInfiniteMonkeys commented 6 years ago

Firstly, many thanks for putting the code together.

Propose on the landing page instructions, the example image path line is changed from: imagePaths: ['modules/MMM-ImageSlideshow/example1']

To: imagePaths: ['modules/MMM-ImageSlideshow/exampleImages']

In order to use the folder included in the distribution as of 17 Nov 2018.

Propose add to instructions, "A different folder may be used by changing the path held in the config.js file. If required change the parameter on line imagePaths:".

Propose add instruction on how to install (Raspberry Pi example) e.g. Using the module

Use Git to download this extension to Magic Mirror. Make sure Git is installed on your system. In the command line/terminal, e.g. 'sudo apt install git'. Next, go to the modules directory of the your Magic Mirror e.g. 'cd /home/pi/MagicMirror/modules'. Run: 'git clone https://github.com/AdamMoses-GitHub/MMM-ImageSlideshow.git'.

The advantage of using Git is when there is an update, you can run 'git pull' and it will pull down all the updates. Magic Mirror can even let you know when there are updates.

Note instructions above mercilessly 'stolen' and adapted, possibly improved ;-), from other instructions on GitHub.

I hope the above are a positive contribution, again. Thanks again, OneOfTheInfiniteMonkeys.

r4zi3lrrr commented 5 years ago

Hi,

I'm trying to run the below:

module: 'MMM-ImageSlideshow', position: 'bottom_left', config: { imagePaths: ['modules/MMM-ImageSlideshow/example1'] fixedImageWidth:250 fixedImageHeight:450

But it stops the Magic Mirror software from running and complains about the config file having an issue. Any ideas what I'm doing wrong, please?

OneOfTheInfiniteMonkeys commented 5 years ago

Hi, I am just another user. Additionally this thread isn't really the right place to post a support request.

Having said all that: Your syntax appears incorrect, you MUST pay attention to the commas and braces etc. Some say even using spaces or tabs make a difference. No commas after entries in the "config: {" section.

Here is the snippet from my (working) setup that might be of assistance: { module: "MMM-ImageSlideshow", position: "middle_center", config: { fixedImageWidth: 600, imagePaths: ["modules/MMM-ImageSlideshow/exampleImages"], } },

Note the commas etc. as previously mentioned. The path above also allows the "current" distribution to display the default images (or yours if you put them in that folder).

Hope this is of assistance.

Post edit, it has removed the TABS and I don't know how to format them into this post, apologies.

OneOfTheInfiniteMonkeys.

OneOfTheInfiniteMonkeys commented 5 years ago

P.S. Found this recently... npm run config:check

see here https://forum.magicmirror.builders/topic/5399/how-to-check-your-config-for-errors-for-absolute-beginners

r4zi3lrrr commented 5 years ago

Hi, Oh ok that's probably why I'm still getting no joy with the example code you provided - thanks for trying though.

I'll try that npm run config:check command and see what I get.

FritsBolt commented 5 years ago

Knowing that this is not the place to post a support request <where should I (NEWBE) put that?> please help me with this: the MMM-ImageSlideshow is installed,no errors, BUT no (example)image is shown.Just a little icon in the left corner of the frame set FixesImageWidth and -Heigth (i.e.300) Maybe cause I realy donot understand what to do with the HTML code that was provided in the README.md
kind regards, and thanks a lot Frits (from the Netherlands)

tekst.txt

OneOfTheInfiniteMonkeys commented 5 years ago

Somewhere here I suspect: https://forum.magicmirror.builders/

No doubt you will get a better answer and faster response.

My tip would be check very, very, very carefully the structure of the config.js file.

It's probably the only finle you will be tweaking and as my proposal indicates the default folder effectively points to nothing..

FritsBolt commented 5 years ago

Thanks, I will let you know the result


Van: OneOfTheInfiniteMonkeys notifications@github.com Verzonden: zaterdag, januari 5, 2019 5:05 PM Aan: AdamMoses-GitHub/MMM-ImageSlideshow CC: FritsBolt; Manual Onderwerp: Re: [AdamMoses-GitHub/MMM-ImageSlideshow] Instructions For Newbies (#10)

Somewhere here I suspect: https://forum.magicmirror.builders/

No doubt you will get a better answer and faster response.

My tip would be check very, very, very carefully the structure of the config.js file.

It's probably the only finle you will be tweaking and as my proposal indicatres the default folder effectively points to nothing..

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/AdamMoses-GitHub/MMM-ImageSlideshow/issues/10#issuecomment-451667439, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsO-IPGkfme2ztA2_NfPZaztA_RWIHaPks5vAM1RgaJpZM4YnYb4.

FritsBolt commented 5 years ago

problem solved,thanks

Brtrnd commented 3 years ago

problem solved,thanks

Please don't say "problem solved" but explain what your issue was and how you solved it. It gets you 20 karma points.

benoitv80 commented 2 years ago

Hi, i also need some support on this one, i'd like to have some answers also...

OneOfTheInfiniteMonkeys commented 2 years ago

Hi, if you are having issues with no MagicMirror content appearing at all. It's probable editing the config.js file has resulted in an error in the file. Any (syntax) errors in the config.js file essentially stop the whole thing working (in my experience at least).

Very carefully review the config.js file, perhaps try some of the suggestions above.

Why does it stop completely? It should be noted the config.js file is a part of the code that runs MagicMirror (under Electron via Node.JS). Rather than just a text configuration file holding parameters to be read in by code. Thus accidently introduced JavaScript sytntax errors in the config.js file are handled by the JavaScript interpreter. The interpreter carefully stops things running amok as should be the case. However, it can be a little tricky figuring out what's wrong as these are effectively coding bugs.

These are just the ramblings of another user, though I hope a little better than the vacum of space.