AdamMoses-GitHub / MMM-ImageSlideshow

Displays images one-at-a-time from local folders.
MIT License
43 stars 24 forks source link

Sub-folders fetching #13

Open bolish opened 5 years ago

bolish commented 5 years ago

Hi,

Is it normal or an issue that images included into sub-folders are not shown?

Regards

OneOfTheInfiniteMonkeys commented 5 years ago

Hi, I am just another user. I have 5 sub folders in use with no issues.

I have noticed what I think might be a potential issue with very large >8Mb images. I have to better understand what's happening before reporting that as an issue. Even if its an issue it's probably not MMM-ImageSlideshow that would be the root cause.

The reason I mention the image size is in the event your subfolders contain such large images and it proves to be in issue.

Do make sure the line format is correct for the array details of the sub folders i.e.

imagePaths: [ 'modules/MMM-ImageSlideshow/exampleImages', 'modules/MMM-ImageSlideshow/exampleImages/flab-ride', 'modules/MMM-ImageSlideshow/exampleImages/alton-towers' ],

Especially notice the comma at the end of the line.

Try setting a few smaller images < 2Mb into some sub folders and see if that works as anticiatped.

Hope this helps.

viharm commented 4 years ago

Shouldn't sub-folders be automatically picked up?

OneOfTheInfiniteMonkeys commented 4 years ago

Hi, reading from the documentation:

"imagePaths Array value containing strings. Each string should be a path to a directory where image files can be found."

On my system, a sub folder not explicitly specified in the Array of imagePaths is not used at this time.

I understand there to be a limit on how many images can be managed, ( I seem to recall 2000 was mentioned in an other post ) and I find my RASPI needs a large swap file.

My installation currently has two instances of MMM-ImageSlideshow, one slow and one fast, accessing over 1000 images and a Google Photos viewer with a news feed at the bottom.