search

AdamMoses-GitHub / MMM-ImageSlideshow

Displays images one-at-a-time from local folders.
MIT License
43 stars 24 forks source link

pdf format #17

Open chassain opened 5 years ago

chassain commented 5 years ago

Hello,

thanks for your module. this is perfect for me..only one question. Is it possible to have .pdf on your code ? it could be nice see you !

OneOfTheInfiniteMonkeys commented 5 years ago

Hi, research and testing indicate PDF's are not currently supported 01 Nov 2019 in the Raspberry PI version of electron / Chromium.

A random PDF and a basic text only PDF were tested, neither of which displayed. The test software displayed a white thin frame with icon in the top left, as opposed to the PDF content. Further research also seems to indicate there have been and continue to be issues with native electron support for PDF's.

One further point for consideration would be that as the MMM-ImageSlideshow code currently stands and a PDF viewer might operate. Only the first page would likely be displayed. Displaying additional pages would probably require additional code to iterate through PDF pages, if this was desired / required.

The issue might be considerd scope creep given the intended scope "The MMM-ImageSlideshow module is designed to display images".

Keeping a watch on one or more forks of this software might see inclusion of the feature when electron supports viewing of PDF's as the scope of one of the forks might consider a scope change.

I propose the issue for closure or a candidate for promotion / moving to a wish list / future request once electron supports PDF's.

chassain commented 5 years ago

thanks for response. have a good day