AdamNiederer / cov

An emacs extension for displaying coverage data on your code
GNU General Public License v3.0
76 stars 16 forks source link

Default colors #16

Open xendk opened 6 years ago

xendk commented 6 years ago

As a new user, I found the default coloring confusing. red/green for not-covered/covered makes sense, but red for much covered and green for not so much?

I do like the heavy/med/light coloring mode, I haven't seen that elsewhere, but I think it should follow the color convention of the covered/not-covered. May I suggest red/orange/yellow/green for none/light/med/heavy?

(and I'd like a quick toogle for using backgrounds instead of fringes, but that's another story)

AdamNiederer commented 6 years ago

Hm, maybe red/green/light-green/white or red/green/teal/blue would work for heatmap-style highlighting. That would preserve the "red is bad; green is good" idea in the fringe, but also provide the user with the heatmap data. We might even be able to tint it linearly/logarithmically based on the data, rather than arbitrary thresholds.

ardumont commented 3 years ago

I was confused as @xendk expressed ¯_(ツ)_/¯.

But as it's customizable, here is my take on this. In your emacs configuration routines, you can put the following:

(custom-set-faces
 '(cov-none-face  ((((class color)) :foreground "red")))
 '(cov-light-face ((((class color)) :foreground "orange")))
 '(cov-med-face   ((((class color)) :foreground "yellow")))
 '(cov-heavy-face ((((class color)) :foreground "green"))))

No idea if it's a good idea long term but others might find this helpful nonetheless.

Thanks for the work on this btw ;)