Tests not passing against master

FinnG commented 5 years ago

Whilst investigating #23 I discovered that not all the tests are passing on master. I've not had chance to look at this in depth, but here is the output:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
$ cask exec ert-runner
Loading /Users/xxx/git/cov/cov.el (source)...
.Test cov--coveralls-parse--basic-test backtrace:

  signal(json-string-format ("?\\C-j"))
  apply(signal (json-string-format ("?\\C-j")))
  (setq value-32 (apply fn-30 args-31))
  (unwind-protect (setq value-32 (apply fn-30 args-31)) (setq form-des
  (if (unwind-protect (setq value-32 (apply fn-30 args-31)) (setq form
  (let (form-description-34) (if (unwind-protect (setq value-32 (apply
  (let ((value-32 'ert-form-evaluation-aborted-33)) (let (form-descrip
  (let* ((fn-30 (function equal)) (args-31 (condition-case err (let ((
  (progn (insert "{\"source_files\":[{\"coverage\":[0,null,3,1,2,0,nul
  (unwind-protect (progn (insert "{\"source_files\":[{\"coverage\":[0,
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b
  (lambda nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (sa
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name cov--coveralls-parse--basic-test :doc
  ert-run-or-rerun-test(#s(ert--stats :selector (and t) :tests [#s(ert
  ert-run-tests((and t) (lambda (event-type &rest event-args) (cond ((
  ert-runner/run-tests-batch((and t))
  (let ((stats (ert-runner/run-tests-batch selector))) (kill-emacs (if
  ert-runner/run-tests-batch-and-exit((and t))
  (if ert-runner-verbose (ert-runner/run-tests-batch-and-exit ert-runn
  (let ((test-files (ert-runner--test-files tests)) (test-helper (f-ex
  ert-runner/run()
  apply(ert-runner/run nil)
  commander--handle-command(nil)
  commander-parse(nil)
  (if commander-parsing-done nil (commander-parse (or commander-args (
  eval-buffer(#<buffer  *load*> nil "/Users/xxx/git/cov/.cask
  load-with-code-conversion("/Users/xxx/git/cov/.cask/26.1/el
  load("/Users/xxx/git/cov/.cask/26.1/elpa/ert-runner-2018083
  command-line-1(("-scriptload" "/Users/xxx/git/cov/.cask/26.
  command-line()
  normal-top-level()

Test cov--coveralls-parse--basic-test condition:

    (json-string-format "?\\C-j")

F........................

Ran 26 tests in 0.644 seconds
1 unexpected results:
   FAILED  cov--coveralls-parse--basic-test

thoni56 commented 4 years ago

Ditto.

snogge commented 3 years ago

All tests seem to pass on master right now. Was it maybe fixed in 6afabab4daedc96a1677891d41a6e235dd622fd3 ?

snogge commented 2 years ago

Hey @AdamNiederer and @thoni56, this issue appears to be fixed. Would either of you mind to close it?

thoni56 commented 2 years ago

Test pass on master here too. But I can't close.

snogge commented 2 years ago

Sorry, I meant to mention the original reporter @FinnG.

AdamNiederer / cov

Tests not passing against master #24