AdamOswald / tes

2 stars 1 forks source link

Update SonarSource/sonarcloud-github-action digest to db50107 #120

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
SonarSource/sonarcloud-github-action action digest cb201f3 -> db50107

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

viezly[bot] commented 1 year ago

Pull request by bot. No need to analyze

performance-testing-bot[bot] commented 1 year ago

Unable to locate .performanceTestingBot config file

difflens[bot] commented 1 year ago

View changes in DiffLens

guide-bot[bot] commented 1 year ago

Thanks for opening this Pull Request! We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

  2. Complete the activities.

    Action: Complete If you want to rebase/retry this PR, check this box

    If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

senior-dev-bot[bot] commented 1 year ago

Senior-Dev Bot :robot:

Diff 1:

The code changes look fine. However, it's always a good practice to avoid hard-coding secrets and use environment variables instead. Additionally, it's good to have a clear naming convention for secrets to avoid any confusion. Here's an example of how you can modify the code:

      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        SONAR_TOKEN: ${{ secrets.MY_PROJECT_SONAR_TOKEN }}

This way, you're not hard-coding the token name and it becomes more secure.