AdamOswald / tes

2 stars 1 forks source link

Update actions/setup-go action to v4 #128

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/setup-go action major v3 -> v4

Release Notes

actions/setup-go ### [`v4`](https://togithub.com/actions/setup-go/compare/v3...v4) [Compare Source](https://togithub.com/actions/setup-go/compare/v3...v4)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

performance-testing-bot[bot] commented 1 year ago

Unable to locate .performanceTestingBot config file

viezly[bot] commented 1 year ago

Pull request by bot. No need to analyze

difflens[bot] commented 1 year ago

View changes in DiffLens

guide-bot[bot] commented 1 year ago

Thanks for opening this Pull Request! We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

  2. Complete the activities.

    Action: Complete If you want to rebase/retry this PR, check this box

    If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

senior-dev-bot[bot] commented 1 year ago

Senior-Dev Bot :robot:

Diff 1:

Updating the setup-go action to v4 is a worthwhile change as it provides better Go version management and improved reliability. However, we should also use the recommended syntax of setting the version variable explicitly instead of relying on the action's default behavior. We can do this by adding go-version: ${{ matrix.go-version }} to the with block and defining a matrix of Go versions at the top level of our workflow YAML.

jobs:
  build:
    strategy:
      matrix:
        go-version: [1.17, 1.18, 1.19]
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Set up Go
      uses: actions/setup-go@v4
      with:
        go-version: ${{ matrix.go-version }}

Diff 2:

Updating to the latest version of setup-go action is a good practice to ensure compatibility with other dependencies. Additionally, it would be best to move the token parameter into the with block for generate-stackaid-json action to improve readability and maintainability.

- uses: actions/setup-go@v3 # Only required for Go based repos
+ uses: actions/setup-go@v4 # Only required for Go based repos
- uses: stackaid/generate-stackaid-json@v1.9
+ uses: stackaid/generate-stackaid-json@v1.10
  with:
    token: ${{ secrets.STACKAID_ACCESS_TOKEN }}