AdamOswald / tes

2 stars 1 forks source link

Update gradle/gradle-build-action digest to 9cf9903 #131

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
gradle/gradle-build-action action digest 6778644 -> 9cf9903

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

viezly[bot] commented 1 year ago

Pull request by bot. No need to analyze

performance-testing-bot[bot] commented 1 year ago

Unable to locate .performanceTestingBot config file

guide-bot[bot] commented 1 year ago

Thanks for opening this Pull Request! We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

  2. Complete the activities.

    Action: Complete If you want to rebase/retry this PR, check this box

    If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

difflens[bot] commented 1 year ago

View changes in DiffLens

senior-dev-bot[bot] commented 1 year ago

Senior-Dev Bot :robot:

Diff 1:

It's great to see you updating the Gradle build action. To improve maintainability, I suggest creating a variable for the Gradle version to make it easier to update in the future. Additionally,for a secure way to handle secrets, it's best to use secrets instead of environment variables for the credentials. Lastly, consider using lossless compression for the GitHub Packages publishing process to decrease file download time.

Code:

- name: Build with Gradle
+ name: Build with Gradle v7.0.2
  uses: gradle/gradle-build-action@9cf99034d287025d4ee4838498a346d99521aaa4
  with:
    arguments: build
    gradle-version: 7.0.2

- name: Publish to GitHub Packages
  uses: gradle/gradle-build-action@9cf99034d287025d4ee4838498a346d99521aaa4
  with:
    arguments: publish
    gradle-version: 7.0.2
  env:
    USERNAME: ${{ secrets.USERNAME }}
    TOKEN: ${{ secrets.TOKEN }}
- name: Publish to GitHub Packages with Lossless Compression
  uses: actions/upload-artifact@v2
  with:
    name: dist
    path: build/distributions/*
  env:
    USERNAME: ${{ secrets.USERNAME }}
    TOKEN: ${{ secrets.TOKEN }}
    compression-level: 9

Diff 2:

The code change looks good as long as the new Gradle version is compatible with the project's dependencies. To ensure backwards compatibility, it may be a good idea to run integration tests on the new Gradle version before merging the changes. Additionally, specifying the Gradle version directly may be beneficial for consistency between different environments.

Example: