AdamOswald / tes

2 stars 1 forks source link

Update tj-actions/changed-files action to v40 [SECURITY] #159

Closed renovate[bot] closed 5 months ago

renovate[bot] commented 5 months ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/changed-files action major v39 -> v40

GitHub Vulnerability Alerts

CVE-2023-51664

Summary

The tj-actions/changed-files workflow allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The changed-files action returns a list of files changed in a commit or pull request which provides an escape_json input enabled by default, only escapes " for JSON values.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to a repository with a new file injecting a command. For example $(whoami).txt which is a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files step below.
      - name: List all changed files
        run: |
          for file in $; do
            echo "$file was changed"
          done

Example output:


##[group]Run for file in $(whoami).txt; do
    for file in $(whoami).txt; do
        echo "$file was changed"
    done
shell: /usr/bin/bash -e {0}

##[endgroup]
runner.txt was changed

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

- name: List all changed files
  env:
    ALL_CHANGED_FILES: $
  run: |
    for file in "$ALL_CHANGED_FILES"; do
      echo "$file was changed"
    done

Resources


Release Notes

tj-actions/changed-files (tj-actions/changed-files) ### [`v40`](https://togithub.com/tj-actions/changed-files/releases/tag/v40) [Compare Source](https://togithub.com/tj-actions/changed-files/compare/v39...v40) ##### Changes in v40.2.3 ##### What's Changed - Upgraded to v40.2.2 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1787](https://togithub.com/tj-actions/changed-files/pull/1787) - chore(deps): update dependency prettier to v3.1.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1788](https://togithub.com/tj-actions/changed-files/pull/1788) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1789](https://togithub.com/tj-actions/changed-files/pull/1789) - chore(deps): update typescript-eslint monorepo to v6.14.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1790](https://togithub.com/tj-actions/changed-files/pull/1790) - chore(deps): update github/codeql-action action to v3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1792](https://togithub.com/tj-actions/changed-files/pull/1792) - chore(deps): update actions/download-artifact action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1793](https://togithub.com/tj-actions/changed-files/pull/1793) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1795](https://togithub.com/tj-actions/changed-files/pull/1795) - chore(deps): update dependency eslint to v8.56.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1796](https://togithub.com/tj-actions/changed-files/pull/1796) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1797](https://togithub.com/tj-actions/changed-files/pull/1797) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1798](https://togithub.com/tj-actions/changed-files/pull/1798) - chore(deps): update actions/setup-node action to v4.0.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1799](https://togithub.com/tj-actions/changed-files/pull/1799) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.2.3 *** ##### Changes in v40.2.2 ##### What's Changed - Upgraded to v40.2.1 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1771](https://togithub.com/tj-actions/changed-files/pull/1771) - chore(deps): update typescript-eslint monorepo to v6.13.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1772](https://togithub.com/tj-actions/changed-files/pull/1772) - chore: Create SECURITY.md by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1773](https://togithub.com/tj-actions/changed-files/pull/1773) - chore: Update package.json by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1774](https://togithub.com/tj-actions/changed-files/pull/1774) - chore(deps-dev): bump [@​types/jest](https://togithub.com/types/jest) from 29.5.10 to 29.5.11 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1775](https://togithub.com/tj-actions/changed-files/pull/1775) - chore(deps): update dependency typescript to v5.3.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1777](https://togithub.com/tj-actions/changed-files/pull/1777) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1778](https://togithub.com/tj-actions/changed-files/pull/1778) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1779](https://togithub.com/tj-actions/changed-files/pull/1779) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1781](https://togithub.com/tj-actions/changed-files/pull/1781) - chore(deps): bump tj-actions/branch-names from 7 to 8 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1782](https://togithub.com/tj-actions/changed-files/pull/1782) - docs: add rodrigorfk as a contributor for code, test, and bug by [@​allcontributors](https://togithub.com/allcontributors) in [https://github.com/tj-actions/changed-files/pull/1785](https://togithub.com/tj-actions/changed-files/pull/1785) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1786](https://togithub.com/tj-actions/changed-files/pull/1786) - fix: bug recovering deleted files for submodules by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1784](https://togithub.com/tj-actions/changed-files/pull/1784) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.2.2 *** ##### Changes in v40.2.1 ##### What's Changed - Upgraded to v40.2.0 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1746](https://togithub.com/tj-actions/changed-files/pull/1746) - chore: update README.md by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1749](https://togithub.com/tj-actions/changed-files/pull/1749) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1750](https://togithub.com/tj-actions/changed-files/pull/1750) - chore(deps): update typescript-eslint monorepo to v6.13.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1751](https://togithub.com/tj-actions/changed-files/pull/1751) - chore(deps): update typescript-eslint monorepo to v6.13.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1753](https://togithub.com/tj-actions/changed-files/pull/1753) - chore: remove unused job by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1754](https://togithub.com/tj-actions/changed-files/pull/1754) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1755](https://togithub.com/tj-actions/changed-files/pull/1755) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1757](https://togithub.com/tj-actions/changed-files/pull/1757) - security: remove usage of pull_request_target event from test.yml by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1758](https://togithub.com/tj-actions/changed-files/pull/1758) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1761](https://togithub.com/tj-actions/changed-files/pull/1761) - test: verify bug writing outputs when files_yaml is used by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1762](https://togithub.com/tj-actions/changed-files/pull/1762) - security: Update test.yml removing pull_request_review event by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1763](https://togithub.com/tj-actions/changed-files/pull/1763) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1764](https://togithub.com/tj-actions/changed-files/pull/1764) - chore(deps): update dependency eslint to v8.55.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1765](https://togithub.com/tj-actions/changed-files/pull/1765) - chore(deps): update dependency eslint-config-prettier to v9.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1766](https://togithub.com/tj-actions/changed-files/pull/1766) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1767](https://togithub.com/tj-actions/changed-files/pull/1767) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1769](https://togithub.com/tj-actions/changed-files/pull/1769) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1768](https://togithub.com/tj-actions/changed-files/pull/1768) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1770](https://togithub.com/tj-actions/changed-files/pull/1770) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.2.1 *** ##### Changes in v40.2.0 ##### What's Changed - Upgraded to v40.1.1 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1704](https://togithub.com/tj-actions/changed-files/pull/1704) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1706](https://togithub.com/tj-actions/changed-files/pull/1706) - chore(deps): update dependency prettier to v3.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1707](https://togithub.com/tj-actions/changed-files/pull/1707) - chore(deps): update typescript-eslint monorepo to v6.11.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1708](https://togithub.com/tj-actions/changed-files/pull/1708) - chore: Update update-readme.yml by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1709](https://togithub.com/tj-actions/changed-files/pull/1709) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1710](https://togithub.com/tj-actions/changed-files/pull/1710) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1711](https://togithub.com/tj-actions/changed-files/pull/1711) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1712](https://togithub.com/tj-actions/changed-files/pull/1712) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1713](https://togithub.com/tj-actions/changed-files/pull/1713) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1714](https://togithub.com/tj-actions/changed-files/pull/1714) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.9.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1715](https://togithub.com/tj-actions/changed-files/pull/1715) - chore(deps): update dependency eslint to v8.54.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1716](https://togithub.com/tj-actions/changed-files/pull/1716) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.9.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1717](https://togithub.com/tj-actions/changed-files/pull/1717) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1720](https://togithub.com/tj-actions/changed-files/pull/1720) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1721](https://togithub.com/tj-actions/changed-files/pull/1721) - chore: simplify matrix example workflow by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1719](https://togithub.com/tj-actions/changed-files/pull/1719) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1722](https://togithub.com/tj-actions/changed-files/pull/1722) - chore(deps): update typescript-eslint monorepo to v6.12.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1723](https://togithub.com/tj-actions/changed-files/pull/1723) - chore(deps): update dependency typescript to v5.3.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1724](https://togithub.com/tj-actions/changed-files/pull/1724) - Bump [@​types/node](https://togithub.com/types/node) from 20.9.2 to 20.9.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1725](https://togithub.com/tj-actions/changed-files/pull/1725) - chore(deps): update dependency [@​types/jest](https://togithub.com/types/jest) to v29.5.9 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1729](https://togithub.com/tj-actions/changed-files/pull/1729) - chore(deps): update dependency [@​types/micromatch](https://togithub.com/types/micromatch) to v4.0.6 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1731](https://togithub.com/tj-actions/changed-files/pull/1731) - chore(deps): update dependency [@​types/lodash](https://togithub.com/types/lodash) to v4.14.202 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1730](https://togithub.com/tj-actions/changed-files/pull/1730) - Bump [@​types/lodash](https://togithub.com/types/lodash) from 4.14.201 to 4.14.202 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1728](https://togithub.com/tj-actions/changed-files/pull/1728) - Bump [@​types/micromatch](https://togithub.com/types/micromatch) from 4.0.5 to 4.0.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1727](https://togithub.com/tj-actions/changed-files/pull/1727) - Bump [@​types/jest](https://togithub.com/types/jest) from 29.5.8 to 29.5.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1726](https://togithub.com/tj-actions/changed-files/pull/1726) - Bump [@​types/node](https://togithub.com/types/node) from 20.9.3 to 20.9.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1732](https://togithub.com/tj-actions/changed-files/pull/1732) - chore(deps): update dependency [@​types/jest](https://togithub.com/types/jest) to v29.5.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1734](https://togithub.com/tj-actions/changed-files/pull/1734) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.9.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1736](https://togithub.com/tj-actions/changed-files/pull/1736) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.10.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1737](https://togithub.com/tj-actions/changed-files/pull/1737) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1743](https://togithub.com/tj-actions/changed-files/pull/1743) - feat: add support for passing branch name to the base_sha and sha inputs by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1742](https://togithub.com/tj-actions/changed-files/pull/1742) - fix: prevent similar commit hashes error when using the branch name by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1744](https://togithub.com/tj-actions/changed-files/pull/1744) - fix: prevent similar commit hashes error when using the branch name by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1745](https://togithub.com/tj-actions/changed-files/pull/1745) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.2.0 *** ##### Changes in v40.1.1 ##### What's Changed - Upgraded to v40.1.0 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1695](https://togithub.com/tj-actions/changed-files/pull/1695) - chore(deps): update dependency eslint to v8.53.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1696](https://togithub.com/tj-actions/changed-files/pull/1696) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1697](https://togithub.com/tj-actions/changed-files/pull/1697) - chore(deps): update typescript-eslint monorepo to v6.10.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1698](https://togithub.com/tj-actions/changed-files/pull/1698) - chore(deps): update dependency [@​types/jest](https://togithub.com/types/jest) to v29.5.8 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1699](https://togithub.com/tj-actions/changed-files/pull/1699) - chore(deps): update dependency [@​types/uuid](https://togithub.com/types/uuid) to v9.0.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1702](https://togithub.com/tj-actions/changed-files/pull/1702) - chore(deps): update dependency [@​types/micromatch](https://togithub.com/types/micromatch) to v4.0.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1701](https://togithub.com/tj-actions/changed-files/pull/1701) - chore(deps): update dependency [@​types/lodash](https://togithub.com/types/lodash) to v4.14.201 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1700](https://togithub.com/tj-actions/changed-files/pull/1700) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.9.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1703](https://togithub.com/tj-actions/changed-files/pull/1703) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.1.1 *** ##### Changes in v40.1.0 ##### What's Changed - Upgraded to v40.0.2 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1689](https://togithub.com/tj-actions/changed-files/pull/1689) - fix(deps): update dependency yaml to v2.3.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1691](https://togithub.com/tj-actions/changed-files/pull/1691) - feat: add support for controlling the pattern order by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1693](https://togithub.com/tj-actions/changed-files/pull/1693) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1694](https://togithub.com/tj-actions/changed-files/pull/1694) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.1.0 *** ##### Changes in v40.0.2 ##### What's Changed - Upgraded to v40.0.1 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1686](https://togithub.com/tj-actions/changed-files/pull/1686) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.8.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1687](https://togithub.com/tj-actions/changed-files/pull/1687) - fix: order of file patterns by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1688](https://togithub.com/tj-actions/changed-files/pull/1688) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.0.2 *** ##### Changes in v40.0.1 ##### What's Changed - Upgraded to v40 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1672](https://togithub.com/tj-actions/changed-files/pull/1672) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1673](https://togithub.com/tj-actions/changed-files/pull/1673) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1675](https://togithub.com/tj-actions/changed-files/pull/1675) - chore(deps): update dependency eslint-plugin-jest to v27.5.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1674](https://togithub.com/tj-actions/changed-files/pull/1674) - chore(deps): update dependency eslint-plugin-jest to v27.6.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1676](https://togithub.com/tj-actions/changed-files/pull/1676) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1677](https://togithub.com/tj-actions/changed-files/pull/1677) - Updated README.md by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1678](https://togithub.com/tj-actions/changed-files/pull/1678) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1680](https://togithub.com/tj-actions/changed-files/pull/1680) - chore(deps): update dependency [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) to v6.9.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1682](https://togithub.com/tj-actions/changed-files/pull/1682) - chore(deps): update dependency [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) to v6.9.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1683](https://togithub.com/tj-actions/changed-files/pull/1683) - fix: bug with order in which the files and files ignore patterns are combined by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1684](https://togithub.com/tj-actions/changed-files/pull/1684) - chore(deps): update dependency [@​types/jest](https://togithub.com/types/jest) to v29.5.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1685](https://togithub.com/tj-actions/changed-files/pull/1685) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v40...v40.0.1 *** ##### Changes in v40.0.0 ##### πŸ”₯ πŸ”₯ Breaking Change πŸ”₯ πŸ”₯ - Directory patterns now require explicit specification of the globstar pattern to match all sub paths. ##### ```diff ... - name: Get specific changed files id: changed-files-specific uses: tj-actions/changed-files@v40 with: files: | - dir + dir/** ``` ##### What's Changed - Upgraded to v39.2.4 by [@​tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1664](https://togithub.com/tj-actions/changed-files/pull/1664) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1665](https://togithub.com/tj-actions/changed-files/pull/1665) - Bump [@​types/node](https://togithub.com/types/node) from 20.8.7 to 20.8.8 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/changed-files/pull/1666](https://togithub.com/tj-actions/changed-files/pull/1666) - chore(deps): update dependency [@​types/node](https://togithub.com/types/node) to v20.8.9 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1668](https://togithub.com/tj-actions/changed-files/pull/1668) - remove: appending globstar pattern for directories to prevent bugs with path matching by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1670](https://togithub.com/tj-actions/changed-files/pull/1670) - chore(deps): lock file maintenance by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1671](https://togithub.com/tj-actions/changed-files/pull/1671) **Full Changelog**: https://github.com/tj-actions/changed-files/compare/v39...v40.0.0 ***

Configuration

πŸ“… Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

aviator-app[bot] commented 5 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
performance-testing-bot[bot] commented 5 months ago

Unable to locate .performanceTestingBot config file

secure-code-warrior-for-github[bot] commented 5 months ago

Micro-Learning Topic: OS command injection (Detected by phrase)

Matched on "command injection"

What is this? (2min video)

In many situations, applications will rely on OS provided functions, scripts, macros and utilities instead of reimplementing them in code. While functions would typically be accessed through a native interface library, the remaining three OS provided features will normally be invoked via the command line or launched as a process. If unsafe inputs are used to construct commands or arguments, it may allow arbitrary OS operations to be performed that can compromise the server.

Try a challenge in Secure Code Warrior

Helpful references
  • OWASP Command Injection - OWASP community page with comprehensive information about command injection, and links to various OWASP resources to help detect or prevent it.
  • OWASP testing for Command Injection - This article is focused on providing testing techniques for identifying command injection flaws in your applications
difflens[bot] commented 5 months ago

View changes in DiffLens

senior-dev-bot[bot] commented 5 months ago

Hi there! :wave: Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

guide-bot[bot] commented 5 months ago

Thanks for opening this Pull Request! We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

  2. Complete the activities.

    Action: Complete If you want to rebase/retry this PR, check this box

    If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

pull-request-quantifier-deprecated[bot] commented 5 months ago

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Extra Small Size : +1 -1 Percentile : 0.8% Total files changed: 1 Change summary by file extension: .yml : +1 -1 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

coderabbitai[bot] commented 5 months ago

[!IMPORTANT]

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.