Middleware skipping - Githubissues

Hi there. First off I'd like to say that this package has been a site saver for sure and a great big thank you!

On to the nitty gritty.

I've done my best to tailor this to the coding style in the examples here so please forgive me if there's a typo or something I am just plain missing.

We've been utilizing this package like such for about a year with current express v4.x and current LTS nodejs with:

app.route('/test').get(userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction }), doSomethingFunction);

... and it's been working fantastic so far.

What we need to do is something like this:

app.route('/test').get(function (req, res, next) {
  userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction })(req, res, next);
}, doSomethingFunction);

... which seems to work well too... however what we really need is something like this...

app.route('/test').get(function (req, res, next) {
  if (someVar) {
    userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction })(req, res, next);
  } else {
    next(); // or use a different ExpressBrute middleware instance
  }
}, doSomethingFunction);

... when this is done express-brute becomes unstable especially during the first few gets and doesn't seem to behave the same when the someVar conditional doesn't exist.

Some general questions after reading a lot of places on the internet including stackoverflow, the README.md, and testing with the new ExpressBrute.MemoryStore for hours:

Are we doing the middleware hopping incorrectly in any of these three code snippet examples? :question:
It seems that putting conditional code on example three blows things up (e.g. no more protection to start) but it appears to work on example two... again is there something up? :question: e.g. what is being missed here? :question: Did I miss the boat? :wink: :smile:

Thank you so much for a moment of your time.

AdamPflug / express-brute

Middleware skipping #57