search

AdamPflug / express-brute

Brute-force protection middleware for express routes by rate limiting incoming requests
MIT License
564 stars 91 forks source link

adding description about proxys to readme #86

Closed fnaquira closed 4 years ago

fnaquira commented 4 years ago

I was struggling before finding this on the issue section. I think it should be on the main readme because some people are still new to some params on Express.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 97.543% when pulling aa7d1b104f2f2b34db018ad6008e9dc6a6bcaf7a on fnaquira:readme-proxy into bc48c35f04d4a09738ff7596f0c6fe4757a22e4a on AdamPflug:master.

AdamPflug commented 4 years ago

I think you're right that this is worth including. Could you also include a link to the relevant express documentation and a warning that the value "true" would allow for bypass of the express brute functionally https://expressjs.com/en/guide/behind-proxies.html

fnaquira commented 4 years ago

Now it is. Thank you for the consideration.

AdamPflug commented 4 years ago

Thanks for contributing :)