search

AdamRaichu / vscode-zip-viewer

An extension which allows for the manipulation of zip files in VS Code.
https://marketplace.visualstudio.com/items?itemName=AdamRaichu.zip-viewer
MIT License
10 stars 0 forks source link

bug: false alerts about Script injections #118

Open KluSe opened 3 weeks ago

KluSe commented 3 weeks ago

Describe the bug The warning about a </style> tag in the additionalCSS property is shown every time the extension is used, even if the property is not set in either user settings or workspace settings.

To Reproduce Steps to reproduce the behavior:

  1. ensure the zipViewer.ZipEdit.additionalCSS property is not set in the user settings.json or the workspace settings.json.
  2. open a zip file using the Zip Viewer Editor.

Expected behavior No error message should be shown.

Environment What type of VS Code were you using when you encountered the problem?

Mac OS Sonoma 14.5 Visual Studio Code Version: 1.91.0 Zip Tools v3.17.0

KluSe commented 3 weeks ago

Taking a quick look, this seems to be the issue:

https://github.com/AdamRaichu/vscode-zip-viewer/blob/64b380d0c37c70b5364dbf486ec0071d59215806/src/ZipEdit.js#L56-L63

The warning should be inside the if condition.