search

AdamRaichu / vscode-zip-viewer

An extension which allows for the manipulation of zip files in VS Code.
https://marketplace.visualstudio.com/items?itemName=AdamRaichu.zip-viewer
MIT License
10 stars 0 forks source link

[editor]: Support pdf in preview #89

Closed aaronlippold closed 5 months ago

aaronlippold commented 7 months ago

Please add support for .pdf files to the editor preview.

Not sure the overall level of effort but hopefully this is just a cross connection to one of the pdf preview extensions that already exist.

Thanks also for a plugin that 'just works' 👍🏻

Generated by adamraichu.zip-viewer

AdamRaichu commented 7 months ago

Interestingly, this is the 4th issue (#32, #86, and #87 being the others) I've had asking for a pdf preview. Maybe you know of something in the vscode api that I don't, but I haven't been able to find an api that allows for opening untitled files that are not text files. Please tell me if you know of other extensions doing something like this!

Because I don't know of any api like that, here is what I've said about this to the other people who asked for a pdf preview.

I'm going to close this as won't fix because pdf documents are not text documents. However, I have made another extension which provides a custom editor for pdf files. You can use the selective extraction feature to get the pdf files from the zip file, then my other extension to view the file.

aaronlippold commented 7 months ago

Is there a way to redirect your zip plug-in to use your PDF plug-in when it runs into a PDF file?

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Sun, Dec 17, 2023 at 16:47 AdamRaichu @.***> wrote:

Interestingly, this is the 4th issue (#32 https://github.com/AdamRaichu/vscode-zip-viewer/issues/32, #86 https://github.com/AdamRaichu/vscode-zip-viewer/issues/86, and #87 https://github.com/AdamRaichu/vscode-zip-viewer/issues/87 being the others) I've had asking for a pdf preview. Maybe you know of something in the vscode api that I don't, but I haven't been able to find an api that allows for opening untitled files that are not text files. Please tell me if you know of other extensions doing something like this!

Because I don't know of any api like that, here is what I've said about this to the other people who asked for a pdf preview.

I'm going to close this as won't fix because pdf documents are not text documents. However, I have made another extension https://github.com/AdamRaichu/vscode-pdf-viewer which provides a custom editor for pdf files. You can use the selective extraction feature https://github.com/AdamRaichu/vscode-zip-viewer#selective-extraction to get the pdf files from the zip file, then my other extension to view the file.

— Reply to this email directly, view it on GitHub https://github.com/AdamRaichu/vscode-zip-viewer/issues/89#issuecomment-1859294076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42DVSP2TBE4M45J4MMLYJ5SATAVCNFSM6AAAAABAYNPFRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGI4TIMBXGY . You are receiving this because you authored the thread.Message ID: @.***>

AdamRaichu commented 7 months ago

I suppose there is, although not with the way my other extension is currently coded. I will think about how to make that happen.

AdamRaichu commented 5 months ago

API for pdf viewer is done. Working on implementing in this extension.

AdamRaichu commented 5 months ago

Sorry for the long wait, this extension is one of many hobby projects, and I let this fall by the wayside. PDF preview is now complete, and should hit the marketplace in a few minutes. Thank you for your patience, and let me know if there are any other features you would like.